Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10072#discussion_r46341268
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -95,7 +95,7 @@ abstract class Expression extends TreeNode[Expression] {
ctx.subExprEliminationExprs.get(this).map { subExprState =>
// This expression is repeated meaning the code to evaluated has
already been added
// as a function and called in advance. Just use it.
- val code = s"/* $this */"
+ val code = s"/* ${this.toString.replace("*/", "\\*\\/")} */"
--- End diff --
Should we put this as a utility in ctx?
Maybe. def escapeComment(< thing to put inside /* */>)
This seems easy to get wrong in the future too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
