Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10073#discussion_r46353328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -133,6 +132,38 @@ object ExtractEquiJoinKeys extends Logging with
PredicateHelper {
}
/**
+ * A pattern that collects the filter and inner joins.
+ *
+ * Filter
+ * |
+ * inner Join
+ * / \ ----> (filters, Seq(plan1, plan2),
input)
+ * inner join plan2
+ * / \
+ * input plan1
+ */
+object FilterAndInnerJoins extends PredicateHelper {
+ def unapply(plan: LogicalPlan): Option[(LogicalPlan, Seq[LogicalPlan],
Seq[Expression])] =
--- End diff --
I know I suggested this interface, but now I'm questioning why we are
differentiating the `input` from `planN`. Is there a reason we shouldn't just
return a single `Seq[LogicalPlan]`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
