Github user dilipbiswal commented on the pull request:

    https://github.com/apache/spark/pull/9981#issuecomment-161203128
  
    @cloud-fan Thank you very much. Actually the the ResolveAliases already has 
the code to inject MultiAlias for resolved Generators. So we are good (thanks 
!!)
    
    One question ..
    Currently in Column.named() , the unresolvedFunction falls throgh the last 
case where it uses PrettyString to alias the column.
    Alias(expr, expr.prettyString)()
    
    In our new approach, at ResolveAliases time, we fall into the other case 
and use a generated alias like  c0. Is this ok ? Or should we try to preserve 
the pretty alias semantics  by introducing new cases for diffferent function 
expressions ? Please let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to