Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10037#discussion_r46393107
--- Diff: R/pkg/R/generics.R ---
@@ -623,6 +623,10 @@ setGeneric("getItem", function(x, ...) {
standardGeneric("getItem") })
#' @rdname column
#' @export
+setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
--- End diff --
It won't uniform the ```isNaN``` and ```isnan``` interface at SQL side,
please refer the comments at #10056. Further more, there are different
semantics between Scala and Java about ```isnull```. So let's narrow this PR to
provide the same functions as Scala at SparkR side, this is my original
motivation. I will add test cases for column as @sun-rui suggested. Then I
think this PR can be merged firstly and we start to discuss corresponding alias
or explanations about the ```NULL/NA``` difference. @sun-rui @felixcheung
@shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
