Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10076#discussion_r46394928
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala ---
@@ -51,14 +51,14 @@ private[spark] class TaskResultGetter(sparkEnv:
SparkEnv, scheduler: TaskSchedul
try {
val (result, size) =
serializer.get().deserialize[TaskResult[_]](serializedData) match {
case directResult: DirectTaskResult[_] =>
- if
(!taskSetManager.canFetchMoreResults(serializedData.limit())) {
+ if
(!taskSetManager.canFetchMoreResults(serializedData.remaining())) {
--- End diff --
This looks like it makes a unit test fail. I think you may have to check
the size before the deserializer consumes the byte buffer?
This is overall looking good but we probably have to comb through these a
little more to think through the implications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
