Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10069#discussion_r46397253
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -193,7 +192,7 @@ private[spark] object Task {
dataOut.flush()
val taskBytes = serializer.serialize(task).array()
--- End diff --
Maybe I'm just catching up here and you already discussed this, but
`serialize` already returns a `ByteBuffer` right? why make it an array (does
this call to `array()` need fixing?) and then write it into another one? it can
be cloned directly, if one is worried about the caller modifying the buffer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
