Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10108#discussion_r46459477
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -117,13 +117,9 @@ private[yarn] class YarnAllocator(
// Resource capability requested for each executors
private[yarn] val resource = Resource.newInstance(executorMemory +
memoryOverhead, executorCores)
- private val launcherPool = new ThreadPoolExecutor(
- // max pool size of Integer.MAX_VALUE is ignored because we use an
unbounded queue
- sparkConf.getInt("spark.yarn.containerLauncherMaxThreads", 25),
Integer.MAX_VALUE,
- 1, TimeUnit.MINUTES,
- new LinkedBlockingQueue[Runnable](),
- new ThreadFactoryBuilder().setNameFormat("ContainerLauncher
#%d").setDaemon(true).build())
- launcherPool.allowCoreThreadTimeOut(true)
+ private val launcherPool = ThreadUtils.newDaemonCachedThreadPool(
--- End diff --
The previous codes are right. Just use `newDaemonCachedThreadPool` to make
codes simple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
