Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1165#discussion_r14723528
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -38,7 +38,7 @@ import org.apache.spark.util._
private[spark] sealed trait BlockValues
private[spark] case class ByteBufferValues(buffer: ByteBuffer) extends
BlockValues
private[spark] case class IteratorValues(iterator: Iterator[Any]) extends
BlockValues
-private[spark] case class ArrayBufferValues(buffer: ArrayBuffer[Any])
extends BlockValues
+private[spark] case class ArrayValues(buffer: Array[Any]) extends
BlockValues
--- End diff --
This change was made because `SizeTrackingAppendOnlyBuffer` (used in
`MemoryStore`) is backed by an Array. These values are never mutated anyway, so
it seems somewhat arbitrary that we've been using ArrayBuffers the whole time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
