Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8880#issuecomment-161461449
Hi @winningsix,
There's a lot of test code here that just doesn't apply to Spark and should
be removed, and there are missing tests for stuff you've added in this PR.
Also, the integration tests are in the YARN module while most of the
changes are in core; that's not very optimal. The tests should be as close as
possible to the code being changed / tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
