Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9920#discussion_r46510057
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -255,7 +255,8 @@ private[ml] trait HasFitIntercept extends Params {
private[ml] trait HasHandleInvalid extends Params {
/**
- * Param for how to handle invalid entries. Options are skip (which will
filter out rows with bad values), or error (which will throw an errror). More
options may be added later..
+ * Param for how to handle invalid entries. Options are skip (which will
filter out rows with null values), or error
--- End diff --
You've changed the meaning of an existing parameter - this is generally
something we want to avoid doing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
