Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10037#discussion_r46510599
--- Diff: R/pkg/R/generics.R ---
@@ -796,9 +800,17 @@ setGeneric("initcap", function(x) {
standardGeneric("initcap") })
#' @export
setGeneric("instr", function(y, x) { standardGeneric("instr") })
-#' @rdname isNaN
+#' @rdname is.nan
#' @export
-setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
+setGeneric("is.nan")
--- End diff --
please also add a test for base::is.nan if we are masking it. See
https://github.com/yanboliang/spark/blob/spark-12044/R/pkg/inst/tests/test_sparkSQL.R#L931
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
