Github user taishi-oss commented on the pull request:

    https://github.com/apache/spark/pull/8935#issuecomment-161544658
  
    in Pipeline.scala, I have some questions.
    
    
    1. 
    for example, Pipeline.fit was introduced in v1.2.0.
    but, signature was changed in v1.4.0
    
    ```
    v1.2.0: def fit(dataset: SchemaRDD, paramMap: ParamMap): PipelineModel
    v1.4.0: fit(dataset: DataFrame): PipelineModel
    ```
    
    Which should I choose?
    
    There are some methods of which signature is changed.
    for the present, I choose old version.
    
    
    2. 
    "class PipelineModel"'s public valiable "stages" is private until v.1.4.0 
but is public since v.1.4.0.
    
    ```
    hiro [spark] (master) > git show 
v1.2.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val 
stages: Array\[Transformer\]"
        private[ml] val stages: Array[Transformer])
    hiro [spark] (master) > git show 
v1.3.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val 
stages: Array\[Transformer\]"
        private[ml] val stages: Array[Transformer])
    hiro [spark] (master) > git show 
v1.4.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val 
stages: Array\[Transformer\]"
        val stages: Array[Transformer])
    ```
    
    I choose v.1.4.0 but I think v1.2.0 is also collect.
    which should I choose?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to