Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r46532508
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue(args.amQueue)
appContext.setAMContainerSpec(containerContext)
appContext.setApplicationType("SPARK")
+ sparkConf.getOption(CONF_SPARK_YARN_APPLICATION_TAGS)
+ .map(StringUtils.getTrimmedStringCollection(_))
+ .filter(!_.isEmpty())
+ .foreach { tagCollection =>
+ try {
+ // The setApplicationTags method was only introduced in Hadoop
2.4+, so we need to use
+ // reflection to set it, printing a warning if a tag was
specified but the YARN version
+ // doesn't support it.
+ val method = appContext.getClass().getMethod(
+ "setApplicationTags", classOf[java.util.Set[String]])
+ method.invoke(appContext, new
java.util.HashSet[String](tagCollection))
+ } catch {
+ case e: NoSuchMethodException =>
+ logWarning(s"Ignoring $CONF_SPARK_YARN_APPLICATION_TAGS
because this version of " +
+ "YARN does not support it")
+ }
+ }
--- End diff --
using reflect make the code reading more difficult. generally not be
recommanded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
