GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/10155

    [SPARK-12138] [SQL] Escape \u in the generated comments of codegen

    When \u appears in a comment block (i.e. in /**/), code gen will break. So, 
in Expression and CodegenFallback, we escape \u to \\u.
    
    @yhuai Please review it. I did reproduce it and it works after the fix. 
Thanks! 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark escapeU

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10155
    
----
commit 9dc43dde76ac153f70a8a5665461cc0ebcd4cb8b
Author: gatorsmile <[email protected]>
Date:   2015-12-05T02:49:53Z

    escapeU

commit 0e514dbd2b461ed12107cbae304dc643d3c2ac87
Author: gatorsmile <[email protected]>
Date:   2015-12-05T02:53:19Z

    Merge remote-tracking branch 'upstream/master' into escapeU

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to