Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10156#discussion_r46774393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -91,7 +91,7 @@ trait CaseWhenLike extends Expression {
// both then and else expressions should be considered.
def valueTypes: Seq[DataType] = (thenList ++ elseValue).map(_.dataType)
- def valueTypesEqual: Boolean = valueTypes.distinct.size == 1
+ def valueTypesEqual: Boolean =
valueTypes.map(_.asNullable).distinct.size == 1
--- End diff --
I feel it is not the right fix. We cannot just cast them all to nullable. I
feel the best fix should be when we try to find the common type, we understand
non-nullable field can be cast to nullable field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
