Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46789542
--- Diff: R/pkg/R/DataFrame.R ---
@@ -692,8 +696,8 @@ setMethod("sample",
setMethod("sample_frac",
signature(x = "DataFrame", withReplacement = "logical",
fraction = "numeric"),
- function(x, withReplacement, fraction) {
- sample(x, withReplacement, fraction)
+ function(x, withReplacement, fraction, seed) {
+ sample(x, withReplacement, fraction, as.integer(seed))
--- End diff --
Then, you need to change the test case. If we do not use
`as.integer(seed)`, we need to change the input type. For example,
```
sampled2 <- sample(df, FALSE, 0.1, 0)
```
needs to be changed to
```
sampled2 <- sample(df, FALSE, 0.1, 0L)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
