Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10102#discussion_r46898407
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/stat/test/StreamingTest.scala ---
    @@ -17,13 +17,31 @@
     
     package org.apache.spark.mllib.stat.test
     
    +import scala.beans.BeanInfo
    +
     import org.apache.spark.Logging
     import org.apache.spark.annotation.{Experimental, Since}
    -import org.apache.spark.rdd.RDD
    +import org.apache.spark.streaming.api.java.JavaDStream
     import org.apache.spark.streaming.dstream.DStream
     import org.apache.spark.util.StatCounter
     
     /**
    + * Class that represents the group and value of a sample.
    + *
    + * @param isExperiment if the sample is of the experiment group.
    + * @param value numeric value of the observation.
    + */
    +@Since("1.6.0")
    +@BeanInfo
    +case class BinarySample @Since("1.6.0") (
    +    @Since("1.6.0") isExperiment: Boolean,
    --- End diff --
    
    This was not part of the design, but I agree it would be nice someday.  
I'll ping @mengxr  since he reviewed the original PRs, but I think we'll keep 
it as is for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to