Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46918098
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
SharedSQLContext {
checkAnswer(
df.select($"key", functions.json_tuple($"jstring", "f1", "f2", "f3",
"f4", "f5")),
expected)
+
+ checkAnswer(
+ df.selectExpr("key", "json_tuple(jstring, 'f1', 'f2', 'f3', 'f4',
'f5')"),
--- End diff --
@yhuai Hello Yin, just debugged the code a little bit and trying hard to
understand. In the json_tuple function in jsonExpression.scala, we compute the
elementTypes as follows
override def elementTypes: Seq[(DataType, Boolean, String)] =
fieldExpressions.zipWithIndex.map {
case (_, idx) => (StringType, true, s"c$idx")
}
This name is then used while making the generator output in
makeGeneratorOutput() in Analyzer. Do you think we should change this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
