Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9923#discussion_r46954401
--- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala ---
@@ -179,6 +179,24 @@ private[spark] trait RpcEnvFileServer {
*/
def addJar(file: File): String
+ /**
+ * Adds a local directory to be served via this file server.
+ *
+ * @param baseUri Leading URI path (files can be retrieved by appending
their relative
+ * path to this base URI). This cannot be "files" nor
"jars".
+ * @param path Path to the local directory.
+ * @return URI for the root of the directory in the file server.
+ */
+ def addDirectory(baseUri: String, path: File): String
+
+ /** Validates and normalizes the base URI for directories. */
+ protected def validateDirectoryUri(baseUri: String): String = {
--- End diff --
would be better to have a unit test for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
