Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10170#discussion_r47000196
--- Diff:
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
@@ -110,6 +110,12 @@ private[spark] class UnifiedMemoryManager
private[memory] (
evictedBlocks: mutable.Buffer[(BlockId, BlockStatus)]): Boolean =
synchronized {
assert(onHeapExecutionMemoryPool.poolSize + storageMemoryPool.poolSize
== maxMemory)
assert(numBytes >= 0)
+ if (numBytes > maxMemory) {
+ // Fail fast if the block simply won't fit
+ logInfo(s"Will not store $blockId as the required space ($numBytes
bytes) exceeds our " +
+ s"memory limit ($maxMemory bytes)")
--- End diff --
this check is actually duplicated now that you've removed it from
`ensureFreeSpace`, but I can see that it stops us from even resizing the memory
pools early so it's OK to keep here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
