Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9939#discussion_r47045951
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -529,7 +529,7 @@ class LinearRegressionSummary private[regression] (
val predictionCol: String,
val labelCol: String,
val model: LinearRegressionModel,
- val diagInvAtWA: Array[Double]) extends Serializable {
+ private val diagInvAtWA: Array[Double]) extends Serializable {
--- End diff --
@jkbradley I vote for private at present. Users will care about
```coefficientStandardErrors```, ```tValues``` and ```pValues``` which are
calculated by ```diagInvAtWA``. Meanwhile users can not get ```diagInvAtWA```
at R by public interface. @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
