GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/10216
[SPARK-10509][PYSPARK] Reduce excessive param boiler plate code
The current python ml params require cut-and-pasting the param setup and
description between the class & ```__init__``` methods. Remove this possible
case of errors & simplify use of custom params by adding a
```_copy_new_parent``` method to param so as to avoid cut and pasting (and cut
and pasting at different indentation levels urgh).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark
SPARK-10509-excessive-param-boiler-plate-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10216
----
commit 564339bb54635df084fadb813eb8a26e9fe6c8b9
Author: Holden Karau <[email protected]>
Date: 2015-12-09T04:24:34Z
Add a copy to new parent function to make it easier to handle custom params
commit 429172b65e7a193d86286ee05a7f797cee634050
Author: Holden Karau <[email protected]>
Date: 2015-12-09T04:24:42Z
Use the copy to new parent function for custom params
commit a976b78969fb5392df82c8b486126606857ac3da
Author: Holden Karau <[email protected]>
Date: 2015-12-09T04:34:08Z
Add an explicit test for the only copying new parent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
