Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/8683#discussion_r47100268
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -628,6 +628,11 @@ private[spark] class TaskSetManager(
// here "result.value()" just returns the value and won't block other
threads.
sched.dagScheduler.taskEnded(
tasks(index), Success, result.value(), result.accumUpdates, info,
result.metrics)
+ // kill other attempts of this task when speculation is enabled.
--- End diff --
I am not so sure about this part, but will that be better if we moved the
code after we confirmed the task succeeded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
