Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10203#discussion_r47129888
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -124,8 +125,7 @@ private[kinesis] class KinesisReceiver[T](
private val seqNumRangesInCurrentBlock = new
mutable.ArrayBuffer[SequenceNumberRange]
/** Sequence number ranges of data added to each generated block */
- private val blockIdToSeqNumRanges = new mutable.HashMap[StreamBlockId,
SequenceNumberRanges]
- with mutable.SynchronizedMap[StreamBlockId, SequenceNumberRanges]
+ private val blockIdToSeqNumRanges = new ConcurrentHashMap[StreamBlockId,
SequenceNumberRanges]
--- End diff --
I don't think you need to fix this -- but I think the style convention is
to use () when the invocation has a side effect and I'd argue that constructors
always do. I should have said it earlier but don't know that it's worth
changing as the original call didn't either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
