Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8785#discussion_r47206871
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
 ---
    @@ -75,6 +75,18 @@ private[sql] object JDBCRelation {
         }
         ans.toArray
       }
    +
    +  def getEffectiveProperties(
    +      connectionProperties: Properties,
    +      extraOptions: scala.collection.Map[String, String] = Map()): 
Properties = {
    +    val props = new Properties()
    +    extraOptions.foreach { case (key, value) =>
    --- End diff --
    
    Sorry, only now really thinking through this -- if you import 
`scala.collection.JavaConverters._` then this clause can just be 
`props.putAll(extraOptions.asJava)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to