Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10243#issuecomment-163720242
+1 to @rxin concerns on wrapping. A good rule of thumb is to always break
at the highest syntatic level (not in the middle of some construct like a list
of arguments). Otherwise you break things up that are actually the same and
create an artificial separation.
```scala
// No
def getPath: Expression = path.getOrElse(BoundReference(0,
inferDataType(typeToken)._1,
nullable = true))
// Yes
def getPath: Expression =
path.getOrElse(BoundReference(0, inferDataType(typeToken)._1, nullable =
true))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
