Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r47430147
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -534,8 +577,15 @@ class Word2VecModel private[spark] (
// Need not divide with the norm of the given vector since it is
constant.
val cosVec = cosineVec.map(_.toDouble)
var ind = 0
+ var vecNorm = 1f
+ if (norm) {
--- End diff --
As the comment says it's not normalized just because it doesn't affect
ordering. However, the API promises a "cosine similarity", and that's not what
it is. Since it need only be applied to the result, I think it should be an
actual cosine similarity. I do not think it should have a flag, no.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
