Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/10228#issuecomment-164284205
  
    @hvanhovell Yea, it's great to think about how to use a single rule to 
handle aggregation queries with distinct after we have this improvement. The 
logical rewriter rules probably is a good place because rewriting logical plans 
is easier. If it is the right approach, we can make some changes to our 
physical planner to make it respect the aggregation mode of an agg expression 
in a logical agg operator (right now, our physical planner always ignore the 
mode). So, when we create physical plan, we can understand that, for example, a 
logical agg operator is used to merge aggregation buffers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to