Github user sun-rui commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10281#discussion_r47456558
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -1448,23 +1457,28 @@ test_that("write.df() on DataFrame and works with 
read.parquet", {
       expect_equal(count(df), count(parquetDF))
     })
     
    -test_that("read.parquet()/parquetFile() works with multiple input paths", {
    +test_that("read.parquet()/parquetFile() and 
write.parquet()/saveAsParquetFile()", {
    --- End diff --
    
    How about renaming this test case to "read/write Parquet files", where 
read.parquet(), parquetFile(), read.df(), write.parquet(), saveAsParquetFile(), 
write.df() are tested to read/write json files. This test case can be merged 
with the one "write.df() as parquet file"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to