Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r47530742
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -43,6 +44,18 @@ class WeightedLeastSquaresSuite extends SparkFunSuite
with MLlibTestSparkContext
Instance(23.0, 3.0, Vectors.dense(2.0, 11.0)),
Instance(29.0, 4.0, Vectors.dense(3.0, 13.0))
), 2)
+
+ /*
+ R code:
+ same as above except make the label constant
--- End diff --
IMO, comments referencing things like "above" should be avoided since the
code can be rearranged. This comment would be confusing if the above data is
declared in a different place or removed altogether. I don't think think
pointing out that it is the same as the other data is necessary here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
