Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164586802
@yhuai I fixed/addressed/improved most of the things you have raised. Two
things worth pointing out:
You can find the test for UDAF here:
https://github.com/hvanhovell/spark/blob/SPARK-8641-2/sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowSuite.scala#L240-L294
You can find the documentation on how we evaluate a regular
```AggregateFunction``` here:
https://github.com/hvanhovell/spark/blob/SPARK-8641-2/sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala#L705-L712
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
