Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10129#discussion_r47576221
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
@@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(
case i: InterruptedException =>
case e: Throwable => {
failureCount += 1
- if (!NonFatal(e) || failureCount >= reporterMaxFailures) {
+ if
("org.apache.hadoop.yarn.exceptions.ApplicationAttemptNotFoundException".equals(
+ e.getClass().getName())) {
+ val message = "ApplicationAttemptNotFoundException was
thrown " +
+ "from Reporter thread."
+ logError(message, e)
+ finish(FinalApplicationStatus.FAILED,
ApplicationMaster.EXIT_REPORTER_FAILURE,
+ message)
+ } else if (!NonFatal(e) || failureCount >=
reporterMaxFailures) {
--- End diff --
I'm pretty confused about this: @tgravescs @vanzin shouldn't we do this
only for `NonFatal` exceptions? For fatal ones we shouldn't even bother
catching it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
