Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10295#discussion_r47577617
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -85,10 +88,20 @@ case class Generate(
if (join) child.output ++ qualified else qualified
}
+
+ override protected def otherJsonValues: JValue = {
--- End diff --
I would strongly prefer this to be done with reflection as we do in all the
the other functions defined on `TreeNode`. Then we don't have to go a
implement it separately for every LogicalPlan, PhysicalPlan and Expression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
