Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10260#discussion_r47584025
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
 ---
    @@ -251,6 +251,25 @@ case class ExpressionEncoder[T](
     
         val plan = Project(Alias(unbound, "")() :: Nil, LocalRelation(schema))
         val analyzedPlan = SimpleAnalyzer.execute(plan)
    +    if (!analyzedPlan.resolved) {
    +      analyzedPlan match {
    +        // Looked for UpCasts. If these still exist, it indicates they 
could not resolve and
    +        // something about the schemas is mismatched.
    +        case p @ Project(projectList, _) => {
    --- End diff --
    
    Is there a reason to not just put this in `CheckAnalysis` and make it more 
general (i.e. not just `Project`)?  I realize its only used here now, but if we 
ever do use it elsewhere, its invalid to remain after analysis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to