Github user winningsix commented on the pull request:
https://github.com/apache/spark/pull/8880#issuecomment-164617083
@vanzin, I have updated the patch addressing your comments. The following
changes are included:
* Mock the ```SparkEnv``` instead of instantiating a ```SparkContext``` in
```YarnShuffleEncryptionSuite```
* Remove ```initialCredentials``` method in ```YarnShuffleEncryptionSuite```
* Other code style issues addressed
Could you help me review it? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]