Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10312#discussion_r47672218
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -265,10 +266,22 @@ final class DataFrameWriter private[sql](df: 
DataFrame) {
        * @param connectionProperties JDBC database connection arguments, a 
list of arbitrary string
        *                             tag/value. Normally at least a "user" and 
"password" property
        *                             should be included.
    +   * @param columnMapping Maps DataFrame column names to target table 
column names.
    +   *                           This parameter can be omitted if the target 
table has/will be
    --- End diff --
    
    Indent on subsequent lines looks 5 spaces too deep. Unless there's a 
compiler reason it won't work, you can simply make it default to an empty `Map`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to