Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10311#issuecomment-164848287
Other small comments:
- instead of `node-name` I would probably call it `class` and use the
fully qualified classname.
- I think that the best test would be the ability to round trip plans
(serialize them and then turn them back into objects) and then check equality
with the original. If you put this as part of `checkAnswer` then you'll
trivially make it impossible for anyone to ever add nodes where this ability is
broken (assuming they write any tests for it). You could also consider adding
this as a default listener when we initialize a test sql context. It will be
important to print a good error message when this fails so that people
understand why their test is failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
