Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10313#issuecomment-164864825
@naveenminchu, yeah, I'm suggesting that we add a rule to
`scalastyle-config.xml` (like
https://github.com/apache/spark/blob/bc1ff9f4a41401599d3a87fb3c23a2078228a29b/scalastyle-config.xml#L160),
add excludes to ignore the legitimate uses, then fix any violations that we
find (see #7350 for an example of this)
I suppose the Scalastyle lint doesn't catch similar problems in Java code,
but I say "let's not let perfect be the enemy of the good" here; it's better to
have some checks vs. no checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
