Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8885#discussion_r47694407
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -74,19 +80,27 @@ private[history] class HistoryPage(parent:
HistoryServer) extends WebUIPage("")
// page, `...` will be displayed.
if (allAppsSize > 0) {
val leftSideIndices =
- rangeIndices(actualPage - plusOrMinus until actualPage, 1
< _, requestedIncomplete)
+ rangeIndices(actualPage - plusOrMinus until actualPage, 1
< _, requestedIncomplete,
+ requestedQuery)
val rightSideIndices =
rangeIndices(actualPage + 1 to actualPage + plusOrMinus, _
< pageCount,
- requestedIncomplete)
+ requestedIncomplete, requestedQuery)
<h4>
+ <form action="" method="GET">
+ Search: <input type="text" name="query"
value={requestedQuery} />
--- End diff --
It's difficult for users to know the targets searched by keywords. How
about set initial message "Input App Names" or like that to the text field and
remove "Search" label.
It's just one idea. Someone might have better idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
