GitHub user drcrallen opened a pull request:

    https://github.com/apache/spark/pull/10319

    [SPARK-12330] [CORE] Fix mesos coarse mode cleanup

    In the current implementation the mesos coarse scheduler does not wait for 
the mesos tasks to complete before ending the driver. This causes a race where 
the task has to finish cleaning up before the mesos driver terminates it with a 
SIGINT (and SIGKILL after 3 seconds if the SIGINT doesn't work).
    
    This PR causes the mesos coarse scheduler to wait for the mesos tasks to 
finish (with a timeout defined by `spark.mesos.coarse.shutdown.ms`)
    
    This PR also fixes a regression caused by [SPARK-10987] whereby submitting 
a shutdown causes a race between the local shutdown procedure and the 
notification of the scheduler driver disconnection. If the scheduler driver 
disconnection wins the race, the coarse executor incorrectly exits with status 
1 (instead of the proper status 0)
    
    With this patch the mesos coarse scheduler terminates properly, the 
executors clean up, and the tasks are reported as `FINISHED` in the Mesos 
console (as opposed to `KILLED` in < 1.6 or `FAILED` in 1.6 and later)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/metamx/spark SPARK-12330

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10319
    
----
commit 088a6b585fd5a2a73e9ccc1f3252de4f4e2c5ae9
Author: Charles Allen <[email protected]>
Date:   2015-12-15T20:27:45Z

    [SPARK-12330] Make CoarseMesosSchedulerBackend wait for executors to 
cleanup during shutdown
    * Adds `spark.mesos.coarse.shutdown.ms` to tune shutdown wait period

commit 5e1b13d0c5a4edcc5fad4db2011debe0585940dd
Author: Charles Allen <[email protected]>
Date:   2015-12-15T23:41:02Z

    Ignore disconnects notifications during shutdown for 
CoarseGrainedExecutorBackend

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to