Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/9796#discussion_r47732666
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite
// the driver refuses to kill executors it does not know about
syncExecutors(sc)
val executors = getExecutorIds(sc)
+ val executorIdsBefore = executors.head
assert(executors.size === 2)
// kill executor 1, and replace it
assert(sc.killAndReplaceExecutor(executors.head))
eventually(timeout(10.seconds), interval(10.millis)) {
val apps = getApplications()
assert(apps.head.executors.size === 2)
+ val executorIdsAfter = getExecutorIds(sc).head
+ // make sure the old executors head has been killedAndReplaced.
+ assert(executorIdsBefore != executorIdsAfter)
}
var apps = getApplications()
- // kill executor 1
- assert(sc.killExecutor(executors.head))
+ // kill executor 1, and actually nothing to kill
+ assert(!sc.killExecutor(executors.head))
apps = getApplications()
assert(apps.head.executors.size === 2)
--- End diff --
how about this?
```java
val executorKilledAndReplaced = executors.head // The previous head which
is killed and replaced.
assert(!sc.killExecutor(executorKilledAndReplaced))
val executorToKill = executors(1) // The valid executor which is still
working
assert(sc.killExecutor(executorToKill))
val executorAppended = executors(2) // The newly added executor
(replacement)
assert(sc.killExecutor(executorAppended))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
