Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-165022104
It does seem like you would want a separate utility method for handling
configuration values that are intended to be memory sizes.
Don't make up new behavior; just use the behavior from the `Utils` method.
In particular, technically, "k" means 1000 and "Ki" means 1024, but I think we
follow the JVM memory string conventions instead.
I don't see why `toString.toInt` solves an overflow problem. You get a
`long` back, and if one particular value must be an `int`, simply handle
argument checking for that value directly. No need for new methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
