Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8466#discussion_r47845830
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1290,7 +1291,7 @@ class DAGScheduler(
case TaskResultLost =>
// Do nothing here; the TaskScheduler handles these failures and
resubmits the task.
- case other =>
+ case _: ExecutorLostFailure | TaskKilled | UnknownReason =>
--- End diff --
this was needed just for the added test case -- I needed a way to
intentionally throw an error inside the event loop, and with this change if
`event.reason` is `null`, you get an exception.
And yeah, if you add another type but dont' include it in this match,
you'll get a fatal warning in compilation since its a sealed trait.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
