Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7753#discussion_r47849888
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala ---
@@ -65,8 +65,8 @@ private[spark] trait TaskScheduler {
* alive. Return true if the driver knows about the given block manager.
Otherwise, return false,
* indicating that the block manager should re-register.
*/
- def executorHeartbeatReceived(execId: String, taskMetrics: Array[(Long,
TaskMetrics)],
- blockManagerId: BlockManagerId): Boolean
+ def executorHeartbeatReceived(execId: String, executorMetrics:
ExecutorMetrics,
+ taskMetrics: Array[(Long, TaskMetrics)], blockManagerId:
BlockManagerId): Boolean
--- End diff --
I know this was wrong before, but as long as you're touching this -- with
multiline methods, each arg should be on its own line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
