Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10341#issuecomment-165304971
As I talked with @liancheng, this PR is not covering `NOT`, `AND` and `OR`.
This is because `ExpressionTree` is not accessible at Hive 1.2.x.
But as I see Hive's [latest
codes](https://github.com/apache/hive/tree/master/storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg),
this is accessible. So, I think I can add some tests about
`ExpressionTree.Operator` meaning `NOT`, `AND` and `OR` easily after the Hive
version is upgraded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
