Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47871490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -69,6 +68,16 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
}
/**
+ * Set this Decimal to the given BigInt. Will have precision 38 and
scale 0.
+ */
+ def set(intVal: BigInt): Decimal = {
+ this.decimalVal = null
+ this.longVal = intVal.toLong
--- End diff --
Hi Davies: Yes, we need to check the range, otherwise, it will cause
overflow. Thanks. I will look into.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
