Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/9819#issuecomment-165612187
  
    Thank you @hvanhovell ! I am going to merge it. Let's have a follow-up PR 
to add more docs to those newly added functions. Also, can we add tests like 
the following?
    
    ```
    sql(s"""
               |select  p_mfgr,p_name, p_size,
               |avg(null) over(distribute by p_mfgr sort by p_name) as avg
               |from part
          """.stripMargin).show
    
        val df = Seq(("a", 1), ("a", 1), ("a", 2), ("a", 2), ("b", 4), ("b", 
3), ("b", 2))
          .toDF("key", "value")
        val window = Window.orderBy()
          df.select(
              $"key", $"value",
              sum(lit(null)).over(window)).show
    ```
    
    Basically, we test cases using `null` literals as the argument of a window 
function (I tested them manually and the results look good).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to