Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10330#discussion_r47999077
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
    @@ -207,7 +211,7 @@ case class TakeOrderedAndProject(
       private val ord: InterpretedOrdering = new 
InterpretedOrdering(sortOrder, child.output)
     
       // TODO: remove @transient after figure out how to clean closure at 
InsertIntoHiveTable.
    -  @transient private val projection = projectList.map(new 
InterpretedProjection(_, child.output))
    +  @transient private val projection = 
projectList.map(UnsafeProjection.create(_, child.output))
    --- End diff --
    
    Sorry, I still have a dumb question. When calling the `eval` of each of the 
specified expressions, how can we know they can process unsafe rows? Why the 
planner insert unsafe->safe conversion in the original design? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to