Github user Apo1 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10374#discussion_r48016931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala
---
@@ -201,7 +201,7 @@ class GenericRow(protected[sql] val values: Array[Any])
extends Row {
override def toSeq: Seq[Any] = values.toSeq
- override def copy(): Row = this
+ override def copy(): Row = new GenericRow(values.clone())
--- End diff --
Yes it is immutable, but if you want to extract the values of a
GenericRows, change them and create a new row, then it's better to not change
the original values.
So you would first want to copy the original row.
Also the method name copy() implies that it returns a real copy and not the
reference on the original object.
Other rows like GenericInternalRow implement a correct the copy method:
override def copy(): InternalRow = new GenericInternalRow(values.clone())
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
