Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10310#issuecomment-166096808
@QiangCai I think that technically `var partsScanned = 0` in `take` is a
problem since it's incremented by `numPartsToTry` and could overflow causing
`partsScanned < totalParts` to always be true. This is a very rare case where
`numPartsToTry` is large and `totalParts` is close to the max integer, and `n`
is very large.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
